Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMR-10023: Part 2 Reduce Search Logs #2156

Merged
merged 8 commits into from
Aug 5, 2024
Merged

CMR-10023: Part 2 Reduce Search Logs #2156

merged 8 commits into from
Aug 5, 2024

Conversation

jmaeng72
Copy link
Contributor

@jmaeng72 jmaeng72 commented Jul 30, 2024 •
edited
Loading

Overview

What is the feature/fix?

Reducing search logs in the src/cmr/search/services folder

What is the Solution?

Remove some associations logs

What areas of the application does this impact?

Search

Checklist

  • I have updated/added unit and integration tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely with my changes
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@jmaeng72 jmaeng72 requested a review from eereiter July 30, 2024 17:00
@jmaeng72 jmaeng72 self-assigned this Jul 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.11%. Comparing base (65d1ad0) to head (fa2ed7f).

Files Patch % Lines
...ch-app/src/cmr/search/services/tagging_service.clj 0.00% 2 Missing ⚠️
...pp/src/cmr/search/services/association_service.clj 0.00% 1 Missing ⚠️
...mr/search/services/generic_association_service.clj 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
- Coverage   58.11%   58.11%   -0.01%     
==========================================
  Files        1045     1045              
  Lines       70328    70328              
  Branches     2006     2005       -1     
==========================================
- Hits        40873    40872       -1     
+ Misses      27586    27585       -1     
- Partials     1869     1871       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmaeng72 jmaeng72 merged commit 5d79fb4 into master Aug 5, 2024
6 checks passed
@jmaeng72 jmaeng72 deleted the CMR-10023-2 branch August 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isja17 isja17 isja17 approved these changes

@eereiter eereiter eereiter approved these changes

@jceaser jceaser jceaser approved these changes

@zimzoom zimzoom Awaiting requested review from zimzoom

@johnwteague johnwteague Awaiting requested review from johnwteague

Assignees

@jmaeng72 jmaeng72

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmaeng72 @codecov-commenter @jceaser @eereiter @isja17